G-Node / gin-cli

Command line client for GIN
https://gin.g-node.org
Other
12 stars 6 forks source link

User git config file can interfere with gin-cli operations #221

Open achilleas-k opened 5 years ago

achilleas-k commented 5 years ago

If a user has a global configuration or a gin specific configuration somehow, it may interfere with the client's git calls. This can lead to unpredictable behaviour. On the other hand, there may be cases where the user is explicitly configuring the gin-cli behaviour for some reason.

I don't know if we should ignore user configs or respect them.


The issue presented when using the client with a git configuration that specifies a key for logging into gin.g-node.org. When the client was asked to clone a repository, SSH tried to unlock the desktop keyring in order to use the configured key, even though it wouldn't work against the GIN SSH service (the key is used to SSH into the machine's SSH service). Cancelling the unlock continued normally, since the SSH command then used the key provided by the gin client.

achilleas-k commented 5 years ago

Issue popped up again for user with SSH configuration for gin.g-node.org. The userkey was accepted by the server, but it was for a different user than the (gin client) logged in one, and a push operation was rejected.