G-Node / gin-doi

G-Node DOI Service
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

App freeze fix, zip changes and assets mapping #86

Closed mpsonntag closed 3 years ago

mpsonntag commented 3 years ago

This PR introduces the following major and minor changes:

Changes in the DOI registration procedure

Removing the application freeze on git annex uninit

The removal of the derepoCloneDir resolves the issue of very large datasets freezing the registration process on the git annex uninit step. For details see issue #78. It is still unclear why the application freeze had happened, but tests with repositories that consistently froze the service in multiple test runs now succeed without any issues.

Providing the '/assets' content to a docker host

The DOI registration service and the static DOI hosting service both use the same 'assets'. Until now the assets from /assets had to be manually copied to the DOI hosting service when changes to the assets were made after deploying a new version of the DOI registration service. The PR introduces a docker_startup.sh shell script as a new entrypoint for Docker deployment. This script copies the content of the 'assets' folder to the /doidata volume after the docker container has been started. This ensures, that the host, that is using the /doidata volume to statically provide registered DOI datasets, now automatically has access to the same 'assets' as the DOI registration service. Closes #85.

Minor changes

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 614587892


Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/gindoid/config.go 0 1 0.0%
cmd/gindoid/dataset.go 36 81 44.44%
<!-- Total: 48 94 51.06% -->
Files with Coverage Reduction New Missed Lines %
cmd/gindoid/dataset.go 1 12.71%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 554380259: 3.6%
Covered Lines: 207
Relevant Lines: 1673

💛 - Coveralls