search

G-Node / gin-proc

BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Write CI config in yaml format from python #19

Closed mrinalwahal closed 5 years ago

mrinalwahal commented 5 years ago

Currently I'm using a workaround to read the default saved template files of CI configurations and adding required lines after detecting hash break-points. Ex. #add-annex-files

I feel this is an unprofessional way of doing it. Though, it does the job for now, it would be more professional to do this in a more hackable and clean manner using something like pyYAML.

This will also allow us to read the yaml configs at a later stage and only replace the values that we want to, instead of writing and replacing the entire config - as we are doing currently.

achilleas-k commented 5 years ago

I agree. Read in the entire yaml file. Since it's our own template, the service should know which keys need which user-defined values. Then you just write it back with the replaced information.

achilleas-k commented 5 years ago

Closed in #26