search

G-Node / gin-proc

BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Final Phase Week 2 #26

Closed mrinalwahal closed 5 years ago

mrinalwahal commented 5 years ago

Following is done:

  1. Micro-service is now automated with PyYaml - as req in #19.
  2. Supports two diff pipelines (one for snakemake and one custom) - as req in #23
  3. Front-end now only created .drone.yml - as req in #22

  4. 18 could have been closed last week, since the bot passed the checks then itself.

  5. Keys are now ensured upon every login. If they don't exist, then fresh pair is generated and installed for the user. Tested and automated git ops for this with GIT_SSH_COMMAND.

Following is not done:

  1. Drone secrets are not yet installed from gin-proc. This is a quick task for me, however, I'm facing a logical error - Drone only allows us to install secrets per repo. And in gin-proc we are taking the repo from user's during workflow submission, which is the time whence I'm no longer taking auth credentials from user. In this case, either I've have to hard-save the user's credentials in the code for repeatedly using everytime the user pushes to a new repo in gin-proc or I'll have to re-authenticate the user every time xe runs the workflow on a repo they haven't done before - this is to allow me to install the keys for that repo in Drone at the same time.

Following are some errors in the code:

  1. Drone config commands is being appended instead of being over-written. I'm trying to cure this.

(I'm not sure why am I getting the entire commit history in this branch once again even after curing this issues last time. This was supposed to be a vanilla state branch. And that is why the bot is also failing its checks. I'm trying to solve the merge conflicts.)

achilleas-k commented 5 years ago

Looking into it now. Can you check the merge conflicts in the meantime?

achilleas-k commented 5 years ago

Also noticed that when doing the push for the new drone.yml (see below), if any of the steps fail, it runs through and doesn't log the error. In fact, it will print success. https://github.com/G-Node/gin-proc/blob/3d30ee9c98effe491bac19e4dc96a92299760866/back-end/service.py#L262-L265

lgtm-com[bot] commented 5 years ago

This pull request fixes 1 alert when merging ff4e0ceb035ad99eece4a53676c3bc7d672f1e4b into 3d30ee9c98effe491bac19e4dc96a92299760866 - view on LGTM.com

fixed alerts: