search

G-Node / gin-proc

BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Logging #27

Closed mrinalwahal closed 5 years ago

mrinalwahal commented 5 years ago

We can design a debug more for the flask server and enable it with an env variable, something like DEBUG=TRUE during launching of gin-proc container by the user.

Or we could:

May not be a priority right now, but I think its a professional principle to go by. It should make it easier for the user's to debug their server's problem's later.

achilleas-k commented 5 years ago

Print logging is ok for now since when running in Docker, we can access the output using docker log.... We could have the backend check for an env var (e.g., LOG_DIR) and write files to that location if it's specified, otherwise print log by default.

mrinalwahal commented 5 years ago

Finished in #41

achilleas-k commented 5 years ago

Looks good. I'll test it locally and close.