achilleas-k
commented
5 years ago A few more comments:
- All the logging code is duplicated in both config.py and service.py.
- The logging logic isn't the way you describe it (see Michi's comments above).
- The custom
log()function doesn't offer much to begin with. The logging module prints to stderr by default when no filename is specified and it supports setting a loglevel which you already use. So why not just initialise the logging module every time (irrespective ofLOG_DIR) and set the log level. If and whenLOG_DIRis specified, pass it to thefilenameargument islogging.basicConfig(). Then all calls to the customlog()function can be replaced by direct calls to the logging module methods (so instead of doinglog("error", "message")we can just dologging.error("message")and let the logging module take care of the rest.
mrinalwahal
lgtm-com[bot]
Following issues are either resolved, or can simply be closed:
[1] #43 - Now secrets are updated for all repos as soon as the user logs in. [2] #4 - Pipeline steps for restoring and rebuilding the cache have been added - BUT I'm still testing this. [3] #3 - I figured we don't need this since we are not using multiple steps for same dir. Perhaps this issue can either be closed or kept separate for future discussions. [4] #17 - Only important logs are shown to the user now, like critical messages and errors. However, user can now specify a new
DEBUG=Trueenvironment variable, and if they do, all logs even from the DEBUG level will be produced for the user. Otherwise only aforementioned ones.I'm still writing the documentation (see #44 ) and will push it soon.