Done and Dusted - Githubissues

G-Node / gin-proc

BSD 3-Clause "New" or "Revised" License

0 stars 7 forks source link

Done and Dusted #48

Closed mrinalwahal closed 5 years ago

mrinalwahal commented 5 years ago

Following are done:

+ Disabled DEBUG in Flask Server (see #47 ) + Added comments and documented functions inside py packages and API has its own documentation now at <GIN-PROC_SERVER_ADDRESS>:8000/docs/api (see #44) + Enhanced exception handling wherever I could, also added custom exceptions separately for server, service and config (#17 ). + Compartmentalised documentation into separate markdowns (#44 ). + Separated a function solely for specify the initial commands to be used for the workflow, and added an extra exception checkup to confirm whether the mentioned initial commands of the execute step in pipeline are same as that we want or not, if not - then raise the exception and generate a fresh config anyway. + Updated requirements. + Now we overwrite drone configuration if it can't be read for update (#46 ) + Notification by email has been removed from front-end from now, but can be easily re-added at a later stage.

What remains:

- Slack's webhook needs to be updated from your end to make it work. I'm also creating an extra issue for this just so that we don't forget it.

lgtm-com[bot] commented 5 years ago

This pull request introduces 4 alerts and fixes 1 when merging 2d7ce5b80614cc4072592d856c6127bf9bd19f1e into 46fa67413a76faef0722c635a6736ff918733d58 - view on LGTM.com

new alerts:

3 for Unreachable code
1 for Except block handles 'BaseException'

fixed alerts:

1 for Flask app is run in debug mode

lgtm-com[bot] commented 5 years ago

This pull request introduces 1 alert and fixes 1 when merging 66d7fb61221402671749864a39d285c2890ef77f into 46fa67413a76faef0722c635a6736ff918733d58 - view on LGTM.com

new alerts:

1 for Unreachable code

fixed alerts:

1 for Flask app is run in debug mode

lgtm-com[bot] commented 5 years ago

This pull request fixes 1 alert when merging 412fcccee222c7f42f2532bd0081ac18f9015cf1 into 46fa67413a76faef0722c635a6736ff918733d58 - view on LGTM.com

fixed alerts:

1 for Flask app is run in debug mode

lgtm-com[bot] commented 5 years ago

This pull request fixes 1 alert when merging 629e4eb2aa6dbe1b1c90d11721db818494224aef into 46fa67413a76faef0722c635a6736ff918733d58 - view on LGTM.com

fixed alerts:

1 for Flask app is run in debug mode

lgtm-com[bot] commented 5 years ago

This pull request fixes 1 alert when merging c0805d0ce650e5b8b9bc13375c92182d7f8b45bb into 46fa67413a76faef0722c635a6736ff918733d58 - view on LGTM.com

fixed alerts:

1 for Flask app is run in debug mode

lgtm-com[bot] commented 5 years ago

This pull request fixes 1 alert when merging 890174f77f31da5a145673291d3bed01db7e9c00 into 46fa67413a76faef0722c635a6736ff918733d58 - view on LGTM.com

fixed alerts:

1 for Flask app is run in debug mode