search

G-Node / nix-odML-converter

Tool for bi-directional conversion of metadata between NIX and odML files.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

Update to odML version 1.4 & add conversion from nix to odml #1

Closed JuliaSprenger closed 6 years ago

JuliaSprenger commented 6 years ago

This assumes the odml to be saved as a metadata section with name 'odML document' in the NIX file as it is generated by the odML-to-nix converter.

The conversion is now depending on the input file format, so (.odML,. xml) is automatically converted to the corresponding .nix file and vice versa.

JuliaSprenger commented 6 years ago

@achilleas-k: I fixed the issues you mentioned above and added a simple test. However, I noticed that the back and forth conversion is a bit tricky so for now I am only comparing a selected number of attributes. Uncertainties are for example handled differently by nix and odml, so we need to find a way to guarantee the same dtype for these, too.

For uncertainties to be included in the test issues https://github.com/G-Node/nixpy/issues/319 and https://github.com/G-Node/python-odml/issues/294 need to be solved first

achilleas-k commented 6 years ago

I'm going to merge and we can come back to the uncertainties when we finalise a common solution in NIX and odML.

Thanks for the PR.

I'll also open a couple of issues here and maybe set up CI at some point since we have tests.

JuliaSprenger commented 6 years ago

I also suggest to change the repository name to something like 'odML-NIX-converter' since the current one might be misleading now.

achilleas-k commented 6 years ago

Good point. Will do.