search

G-Node / nix-odML-converter

Tool for bi-directional conversion of metadata between NIX and odML files.
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

[nix-odml-conversion] Data Type Errors #26

Open fschrader1992 opened 4 years ago

fschrader1992 commented 4 years ago

When converting nix-files, errors like the following occur occasionally:

TypeError: No NumPy equivalent for TypeBitfieldID exists

This is a problem with the nix-core library, currently these properties are left out of the conversion. Should we achieve conversion of them as well and how?

achilleas-k commented 4 years ago

Do you have an example for a file that causes this? My guess is these are very old files, back when the boolean representation in the file was a bitfield that h5py couldn't read. Here's the relevant issue: https://github.com/G-Node/nixpy/issues/212

I think this change happened in NIXPy 1.2.1 or 1.3.0, so I expect the files will be from 2016 or older.

fschrader1992 commented 4 years ago

Yes, indeed the files showing this error have been created before 2016. An example file is contained in pull request #27. Should we simply not support conversion of these files or is there a way to render them readable for h5py?

achilleas-k commented 4 years ago

I think h5py is still unable to read those, so for now I'd just mark them as unsupported. Maybe at some point we can write a version upgrade tool that uses NIX (the C++ version) to convert them.