search

G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

Visual studio compile fixes #662

Closed The-E closed 7 years ago

The-E commented 7 years ago

While looking through the nix source, I noticed a few areas where nix wasn't compatible with MS' Visual C compiler. This PR fixes those, but there is still more to do in this area; there are a few things I would like to do to make setting up the dependencies used easier.

jgrewe commented 7 years ago

Hi The-E, many thanks for the pull request. We appreciate your help in the windows world a lot! Under Linux (boost 1.54, the current boost version on trusty, i.e. the travis builds) the use of filesystem::path::append breaks. So far we require boost >= 1.49, I would rather keep this dependency.

achilleas-k commented 7 years ago

Hey @The-E, thanks for the PR. As @jgrewe mentioned, we want to keep compatibility with boost 1.49 for NIX on all platforms, even though we don't explicitly test for it on macOS and Windows.

Could you revert the changes that broke compatibility with 1.49? I think it's the path append functions that are the issue, but it's not clear from the Travis logs.

jgrewe commented 7 years ago

closing this one, opened a replacement that also fixes the linux builds