search

G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
67 stars 36 forks source link

CI test fixes, Group creation in RO mode fixes #682

Closed gicmo closed 7 years ago

gicmo commented 7 years ago

Tested the failed didn't make the CI fail (#681). Also PR #679 introduced a regression for entity access in ReadOnly mode; we also lacked a test for that.

achilleas-k commented 7 years ago

Now we need to figure out why Appveyor tests are succeeding.

gicmo commented 7 years ago

@achilleas-k Appveyor is not building the FS backend, and that is the only backend that was/is failing. Good question why the HDF5 one is not.

achilleas-k commented 7 years ago

So like Travis, the test in Appveyor does fail, but the build succeeds.

achilleas-k commented 7 years ago

I think the problem is with the build_script block. It's a single command block, which means that even if the ctest line fails, the next command will execute and if the last one succeeds, the whole block succeeds.

We need to either separate each command on its own line or move the tests to the test_script block.

achilleas-k commented 7 years ago

So are we good to merge this and then open the PR to fix the issues?