search

G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

tagRefsHaveUnits is the same as tagUnitsMatchRefsUnits #739

Closed hkchekc closed 6 years ago

hkchekc commented 6 years ago

https://github.com/G-Node/nix/blob/2e51fbaa0134b62b763dab871d4f2476a2017c92/src/valid/checks.cpp#L25

These two function is identical. It seems like the tagRefsHaveUnits should check only if the number of dimensions match the number of units.

jgrewe commented 6 years ago

good catch @hkchekc ! you are perfectly right, will be fixed soon!

jgrewe commented 6 years ago

closed via #736, thanks for reporting!