G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

[cmake] fix compilation for hdf5 1.10.3 #744

Closed gicmo closed 6 years ago

gicmo commented 6 years ago

So, HDF5 1.10.3 introduced some breaking API change with a minor version update. Lets blame us for not specifying that we want indeed the 1.10. API; We do this now (H5_USE_110_API) which should fix the issue and hopefully prevent future API breaks. Hands up for everyone who thinks that you need to specify H5_USE_110_API to not break when upgrading from 1.10.2 to 1.10.3 is confusing, to put it mildly. TLDR: assert we want the 1.10 API by specify H5_USE_110_API.