G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
68 stars 36 forks source link

data slice can live with less information #757

Closed jgrewe closed 5 years ago

jgrewe commented 5 years ago

with this pr, the util::dataSlice method automatically fills in missing information (to some extent). That is: start, end, and unit values may be missing or incomplete. If less info is given than there are dimensions defaults are assumed:

General rule: if information is provided, the first value given is assumed to belong to the first dimension the 2nd to the second, etc.

jgrewe commented 5 years ago

there are three remaining warnings under windows. one is a config warning (cmake) and the other two are deprecation warnings (which are intended) during tests, imho, we should keep the tests alive as long as the functions are part of the public API