gicmo commented 5 years ago

Github actions/workflows seem to not be ready for prime time, especially for cross PRs:

status seems to not being reported properly
secrets are (obviously) not being shared and therefore we would have to make the codecov.io token public
github actions need to be activated for the person/repo sending the PR

codecov[bot] commented 5 years ago

Codecov Report

Merging #784 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #784   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files         197     197           
  Lines       12205   12205           
======================================
  Hits        11620   11620           
  Misses        585     585

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17a5b90...f015a52. Read the comment docs.

gicmo commented 5 years ago

I wonder if we should disable valgrind tests because it takes forever and I am not sure anybody is actually looking at the results.

G-Node / nix

Back to travis for CI #784

Codecov Report