search

G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

DataView: Check dims on create #787

Closed achilleas-k closed 4 years ago

achilleas-k commented 4 years ago

Check the dimensions of offset and count on DataView creation and throw appropriate exception.

Fixes #786.

codecov[bot] commented 4 years ago

Codecov Report

Merging #787 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   95.34%   95.34%   +<.01%     
==========================================
  Files         197      197              
  Lines       12206    12212       +6     
==========================================
+ Hits        11638    11644       +6     
  Misses        568      568
Impacted Files Coverage Δ
test/BaseTestDataAccess.cpp 100% <100%> (ø) :arrow_up:
include/nix/DataView.hpp 88.88% <100%> (+8.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 634da03...4e261b0. Read the comment docs.