G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
67 stars 36 forks source link

Tag flexibility #805

Closed jgrewe closed 4 years ago

jgrewe commented 4 years ago

companion to #801 but for master branch

gicmo commented 4 years ago

Now there are merge conflicts and the new DataFrameDimension is missing everywhere ;P

codecov[bot] commented 4 years ago

Codecov Report

Merging #805 into master will increase coverage by 0.05%. The diff coverage is 96.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
+ Coverage   94.66%   94.71%   +0.05%     
==========================================
  Files         177      179       +2     
  Lines       12385    12540     +155     
==========================================
+ Hits        11724    11877     +153     
- Misses        661      663       +2     
Impacted Files Coverage Δ
src/valid/checks.cpp 93.10% <90.90%> (-3.49%) :arrow_down:
src/util/dataAccess.cpp 91.31% <93.10%> (+1.28%) :arrow_up:
test/TestDataType.cpp 95.83% <95.83%> (ø)
include/nix/valid/checks.hpp 100.00% <100.00%> (ø)
src/valid/helper.cpp 100.00% <100.00%> (+8.33%) :arrow_up:
src/valid/validate.cpp 76.84% <100.00%> (+1.61%) :arrow_up:
test/BaseTestDataAccess.cpp 100.00% <100.00%> (ø)
test/Runner.cpp 100.00% <100.00%> (ø)
test/TestDataType.hpp 100.00% <100.00%> (ø)
test/TestValidate.cpp 98.15% <100.00%> (-0.10%) :arrow_down:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1fbfbf...a7d7fd9. Read the comment docs.

jgrewe commented 4 years ago

@achilleas-k @gicmo, I guess I am done with it for now (if the checks pass)

achilleas-k commented 4 years ago

Is this good to go?

gicmo commented 4 years ago

Is this good to go?

I managed to review the code, and that is fine, I have not yet a chance to think through what it actually does. I try again tonight or will default to 'yes' ;)