search

G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

DataFrameDimension #807

Closed jgrewe closed 4 years ago

achilleas-k commented 4 years ago

LGTM. Got a couple of issues for NIXPy out of this.

achilleas-k commented 4 years ago

@gicmo Will you have a look at this or should I go ahead and merge? Not sure what's up with codecov and if we should try to restart it somehow until it's finished.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@de63976). Click here to learn what that means. The diff coverage is 88.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #807   +/-   ##
=========================================
  Coverage          ?   94.66%           
=========================================
  Files             ?      177           
  Lines             ?    12385           
  Branches          ?        0           
=========================================
  Hits              ?    11724           
  Misses            ?      661           
  Partials          ?        0
Impacted Files Coverage Δ
include/nix/base/IDataArray.hpp 100% <ø> (ø)
include/nix/base/IDimensions.hpp 100% <ø> (ø)
backend/hdf5/DimensionHDF5.hpp 100% <ø> (ø)
test/TestValidate.hpp 100% <ø> (ø)
test/BaseTestDataArray.cpp 100% <100%> (ø)
test/TestValidate.cpp 98.24% <100%> (ø)
backend/hdf5/DataArrayHDF5.cpp 89.22% <100%> (ø)
include/nix/valid/checks.hpp 100% <100%> (ø)
test/hdf5/TestDataArrayHDF5.hpp 100% <100%> (ø)
src/valid/validate.cpp 75.22% <100%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de63976...855fefb. Read the comment docs.