jgrewe commented 4 years ago

not completely done yet. Needs a bit more testing and support for column if a default unit is specified

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts when merging d38b62ad9269c8cd88c17511edea37b0bcae79f4 into 91d0d79d4cc6569b7f4582305b78c3515753e9ed - view on LGTM.com

new alerts:

2 for Comparison result is always the same

codecov[bot] commented 4 years ago

Codecov Report

Merging #814 into master will increase coverage by 0.07%. The diff coverage is 98.25%.

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
+ Coverage   94.90%   94.98%   +0.07%     
==========================================
  Files         181      181              
  Lines       12609    12698      +89     
==========================================
+ Hits        11967    12061      +94     
+ Misses        642      637       -5

Impacted Files	Coverage Δ
src/util/dataAccess.cpp	`91.53% <93.18%> (+0.22%)`	:arrow_up:
include/nix/Exception.hpp	`88.37% <100.00%> (+1.52%)`	:arrow_up:
src/Dimensions.cpp	`82.35% <100.00%> (+2.60%)`	:arrow_up:
test/BaseTestDataAccess.cpp	`100.00% <100.00%> (ø)`
test/BaseTestDataArray.cpp	`100.00% <100.00%> (ø)`
test/hdf5/TestDataAccessHDF5.hpp	`100.00% <100.00%> (ø)`
include/nix/DataView.hpp	`75.00% <0.00%> (-12.50%)`	:arrow_down:
backend/hdf5/h5x/H5DataSet.cpp	`98.86% <0.00%> (+1.13%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update feff466...5f3b7ab. Read the comment docs.

jgrewe commented 4 years ago

This is good to go, I think. I will skip the column unit handling for now

G-Node / nix

Data access df dim #814

Codecov Report