G-Node / nix

Neuroscience information exchange format
https://readthedocs.org/projects/nixio/
Other
66 stars 36 forks source link

Overhaul of the indexOf methods and data retrieval ... #823

Closed jgrewe closed 4 years ago

jgrewe commented 4 years ago

companion to #819 but for 1.5 with slight adaptations:

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging dcb454ec7ed978df3bcacace2950d60402b1541d into 89b4120dae056aacf961eb9d21310723da84a116 - view on LGTM.com

new alerts:

codecov[bot] commented 4 years ago

Codecov Report

Merging #823 into master will increase coverage by 0.26%. The diff coverage is 97.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
+ Coverage   95.09%   95.35%   +0.26%     
==========================================
  Files         181      181              
  Lines       12753    13558     +805     
==========================================
+ Hits        12127    12928     +801     
- Misses        626      630       +4     
Impacted Files Coverage Δ
include/nix/Dimensions.hpp 98.95% <ø> (ø)
src/util/dataAccess.cpp 89.70% <87.56%> (-1.60%) :arrow_down:
src/Dimensions.cpp 92.68% <98.32%> (+10.25%) :arrow_up:
test/BaseTestDataAccess.cpp 100.00% <100.00%> (ø)
test/BaseTestDimension.cpp 100.00% <100.00%> (ø)
test/BaseTestMultiTag.cpp 99.67% <100.00%> (ø)
test/BaseTestTag.cpp 99.57% <100.00%> (ø)
test/hdf5/TestDataAccessHDF5.hpp 100.00% <100.00%> (ø)
test/hdf5/TestDimensionHDF5.hpp 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 89b4120...65537ea. Read the comment docs.