G-Node / nixpy

Python library for NIX
https://readthedocs.org/projects/nixpy
Other
19 stars 26 forks source link

[pprint] max_depth=-1 is now default #523

Closed jgrewe closed 2 years ago

codecov-commenter commented 3 years ago

Codecov Report

Merging #523 (92d44db) into master (46d1595) will decrease coverage by 0.01%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   81.28%   81.26%   -0.02%     
==========================================
  Files          81       81              
  Lines       10741    10741              
==========================================
- Hits         8731     8729       -2     
- Misses       2010     2012       +2     
Impacted Files Coverage Δ
nixio/property.py 78.57% <66.66%> (ø)
nixio/section.py 85.66% <100.00%> (ø)
docs/source/examples/spikeFeatures.py 95.40% <0.00%> (-2.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46d1595...92d44db. Read the comment docs.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 79.661% when pulling 940af846f2546a8d7e09e563c7383a22e8ade81b on jgrewe:max_depth into 10d48b4aa6b369be594726d8100d6cc09e9b664c on G-Node:master.

achilleas-k commented 3 years ago

Needs a rebase.

jgrewe commented 3 years ago

@achilleas-k thanks for pinging... Will do but I also need to (re)consider the side effect of this choice on the nixio command line tool, which will then print out the whole metadata tree. Is that a bad choice? I am not sure. If yes, then I will limit the default recursion depth there. What do you think?

achilleas-k commented 3 years ago

I think it's fine to spew everything out by default. It might be a bit annoying, but no more than any other command line tool that produces multiple pages of output by default.

jgrewe commented 2 years ago

@achilleas-k rebased ;)

achilleas-k commented 2 years ago

@achilleas-k rebased ;)

Needs another rebase :smile: Sorry, I should have merged sooner

jgrewe commented 2 years ago

rebased again ;)