search

G-Node / nixpy

Python library for NIX
https://readthedocs.org/projects/nixpy
Other
19 stars 26 forks source link

1.5.1 Autogenerated release tars still say "dev" instead of release #528

Open sanjayankur31 opened 3 years ago

sanjayankur31 commented 3 years ago

While updating the Fedora package, I noticed that the automatically generated release tar here on GitHub still says "dev" in the info.json file:

https://github.com/G-Node/nixpy/archive/refs/tags/1.5.1.tar.gz

because the info.json file at that tag/commit still says so:

https://github.com/G-Node/nixpy/blob/b140b789ee301348d8a07562775860490188f377/nixio/info.json#L2

However, if one uses the released tar (manually generated?), it says "release":

https://github.com/G-Node/nixpy/releases/download/1.5.1/nixio-1.5.1.tar.gz

So they're not quite in sync here, and if one uses a git clone, for example, one would get the version as 1.5.1.dev0 and so on. So, could the info.json file also be updated in the repo when a new release is tagged please so that the release and tagged tar are identical?

achilleas-k commented 3 years ago

Hi. Thanks for the report. It seems there was a mistake in the latest release and the tagged commit didn't contain the usual info updating. We'll make sure to fix it and push out a new release soon. Sorry for the trouble.

I'll keep this issue open until the new release is out.

jgrewe commented 3 years ago

This issue should be resolved with the latest 1.5.2 release