G-Node / nixworks

Python package with nix-helpers
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Interactive widgets supporting nix on jupyter notebook #5

Closed hkchekc closed 5 years ago

hkchekc commented 5 years ago

This PR provides basic function of interacting with visualized nix data on jupyter notebook:

Also, added some init files.

lgtm-com[bot] commented 5 years ago

This pull request introduces 14 alerts when merging c920b168d67e656e5dfdcc4e1da96a155e0c2b77 into 172e13558f45aaa04664624b2c862664533e3f54 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 5 years ago

This pull request introduces 17 alerts when merging 3f66906fc4a3903e076d187d71f66df15c3242c2 into 172e13558f45aaa04664624b2c862664533e3f54 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 5 years ago

This pull request introduces 4 alerts and fixes 2 when merging 3248a904ab852a9297406be9927fd55eedb1c928 into 172e13558f45aaa04664624b2c862664533e3f54 - view on LGTM.com

new alerts:

fixed alerts:

hkchekc commented 5 years ago

@jgrewe Maybe do you have any suggestions on what functions can be added?

achilleas-k commented 5 years ago

It's nice to have an example, but if the file isn't in the repository, or available somewhere, it's not very useful. Could use one of the files in https://gin.g-node.org/G-Node/nix-examples/ the same way it was recently added to an example script by @jgrewe in the NIX repo: https://github.com/G-Node/nix/blob/4565c2d7b363f27cac88932b35c085ee8fe975a1/docs/code/relacs_example.py#L105-L122

achilleas-k commented 5 years ago

Nice work. I loaded the relacs example and played around with it a bit. A few bugs here and there, but good POC.

There's a bug when plotting data arrays with set dimensions. I think fix that before we merge and then we can continue with more features and enhancements for followup PRs.

lgtm-com[bot] commented 5 years ago

This pull request introduces 4 alerts and fixes 2 when merging e43713d62c664b0609a6be50d01e8e0231a82e40 into 172e13558f45aaa04664624b2c862664533e3f54 - view on LGTM.com

new alerts:

fixed alerts:

jgrewe commented 5 years ago

@hkchekc I am actually not the Jupyter notebook guy and had to setup my computer after HDD breakdown today. Will have a closer look tomorrow. Wanted to bring up the examples in the nix docs (as @achilleas-k pointed out earlier).

jgrewe commented 5 years ago

in addition to the bug @achilleas-k pointed at, I think I would appreciate the following two points:

hkchekc commented 5 years ago

@jgrewe I think I will add those in the next PR. But I don't really understand the first point, Do you mean to move the nix file to the current directory when it is interacted with?

Also I want to ask if you have some example data files for not only Line and Events plotter, but also Images and bar charts.

lgtm-com[bot] commented 5 years ago

This pull request introduces 4 alerts and fixes 2 when merging 0ca7ec0a9190e776544fbc3f78aea8e6eba7d5b8 into 172e13558f45aaa04664624b2c862664533e3f54 - view on LGTM.com

new alerts:

fixed alerts:

jgrewe commented 5 years ago

@hkchekc the file download is what I meant :) we do have the test file for nixview (https://github.com/bendalab/NixView/blob/master/test/nix_test.h5) that contains image data.