G-Node / python-odml

odML libraries
http://g-node.github.io/python-odml/
BSD 4-Clause "Original" or "Old" License
24 stars 30 forks source link

Property values cardinality implementation #374

Closed mpsonntag closed 4 years ago

mpsonntag commented 4 years ago

This PR is supposed to show by example how a cardinality implementation (see issue #361) could look like and provides more grounds for discussion.

The current PR adds the basic cardinality implementation for Property.values. It provides

Tests will still be pushed to this PR.

The PR should serve as a basis for discussion before the cardinality feature can be extended to sections and properties as well.

mpsonntag commented 4 years ago

As further basis for discussion here is an outline of the current cardinality features:

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.6%) to 76.329% when pulling 79e5acf0b405627fc5c7a008ed4972bed3fcbbfe on mpsonntag:card into d9d52231dd5fb1c7b400736cfe797ba487517c57 on G-Node:master.

mpsonntag commented 4 years ago

When we have figured out the details in the discussion, the concept will also be applied to cardinalities of Sections and Properties, yes.

mpsonntag commented 4 years ago

I'm preparing tests for all new features and will push them once we are happy with the current state of the PR.

mpsonntag commented 4 years ago

Pushed tests for hopefully all added features.

achilleas-k commented 4 years ago

@jgrewe I guess you want to review the changes since your approval before merging?