Adding Section sections cardinality

G-Node / python-odml

odML libraries

http://g-node.github.io/python-odml/

BSD 4-Clause "Original" or "Old" License

24 stars 30 forks source link

Adding Section sections cardinality #384

Closed mpsonntag closed 4 years ago

mpsonntag commented 4 years ago

The current PR adds the basic cardinality implementation for Section.sections. It

provides an update in the Section.__init__.
adds Section.sec_cardinality accessor methods.
adds a Section.set_sections_cardinality convenience method.
adds and registers a Section sections cardinality validation.
provides tests for the implemented features.

The PR refers to issue #361.

coveralls commented 4 years ago

Coverage increased (+0.09%) to 76.717% when pulling bbecc62cb82756457cf4fe48368e90202e58f597 on mpsonntag:cardSecB into 13fd740d24f3d3def8f532c34ec8ae7bc7b1752a on G-Node:master.

achilleas-k commented 4 years ago

Want a second review or are we good to merge?

achilleas-k commented 4 years ago

I think we should open an issue about it and see what people think :)