search

G-Node / tonic

Framework for building services that interact with GIN
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Form enhancements #22

Closed achilleas-k closed 4 years ago

achilleas-k commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into master will increase coverage by 15.02%. The diff coverage is 60.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
+ Coverage   35.09%   50.11%   +15.02%     
===========================================
  Files           9        8        -1     
  Lines         550      419      -131     
===========================================
+ Hits          193      210       +17     
+ Misses        340      189      -151     
- Partials       17       20        +3
Impacted Files Coverage Δ
tonic/routes.go 6.49% <0.00%> (-1.35%) :arrow_down:
tonic/worker/worker.go 87.50% <63.63%> (-5.73%) :arrow_down:
tonic/form/forms.go 88.09% <88.09%> (ø)
tonic/service.go 63.75% <90.90%> (+2.41%) :arrow_up:
tonic/db/db.go 55.55% <0.00%> (-8.09%) :arrow_down:
tonic/db/job.go 65.38% <0.00%> (-6.50%) :arrow_down:
tonic/db/session.go 73.33% <0.00%> (-5.62%) :arrow_down:
tonic/web/web.go 81.08% <0.00%> (-2.26%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8129f25...33b2350. Read the comment docs.

achilleas-k commented 4 years ago

Added some tests for the form element rendering, slavishly trying to increase test coverage.

achilleas-k commented 4 years ago

On second thought, @jcolomb please confirm the changes, lets merge with the doc change and I'll make the change to the code and form later. There are a couple of things we might have to clarify regarding users and teams.