G-Node / tonic

Framework for building services that interact with GIN
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Labproject team creation #26

Closed achilleas-k closed 3 years ago

achilleas-k commented 3 years ago

Lab project form now allows specifying the team name. Closes #24.

This allows multiple projects to be added to the same team, if the specified team already exists. In this case, the user is not added to the existing team. This creates an issue where the project will be created and added to the team, but the user wont be. Unfortunately, testing a user for team membership isn't supported by the GIN API currently, so this will have to be changed in the future (issue #25).

The ValueMap that supplies the values supplied through the form has been changed to accommodate fields that can specify multiple values (checkboxes). Closes #23.

Checkboxes and radio buttons are now fully supported.

codecov[bot] commented 3 years ago

Codecov Report

Merging #26 into master will decrease coverage by 0.82%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   50.11%   49.29%   -0.83%     
==========================================
  Files           8        8              
  Lines         419      428       +9     
==========================================
+ Hits          210      211       +1     
- Misses        189      195       +6     
- Partials       20       22       +2     
Impacted Files Coverage Δ
tonic/db/job.go 65.38% <ø> (ø)
tonic/routes.go 6.28% <0.00%> (-0.21%) :arrow_down:
tonic/form/forms.go 81.25% <50.00%> (-6.85%) :arrow_down:
tonic/worker/worker.go 87.03% <100.00%> (-0.47%) :arrow_down:
tonic/db/session.go 80.00% <0.00%> (+6.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1dc8d17...fc21827. Read the comment docs.