search

G-Node / tonic

Framework for building services that interact with GIN
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Update labproject.md #32

Closed jcolomb closed 3 years ago

jcolomb commented 3 years ago

worked the doc, especially made it clearer what the bot user and the logged-in users are.

codecov[bot] commented 3 years ago

Codecov Report

Merging #32 (f40bd88) into master (a1d9138) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   45.18%   45.18%           
=======================================
  Files           8        8           
  Lines         467      467           
=======================================
  Hits          211      211           
  Misses        234      234           
  Partials       22       22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1d9138...f40bd88. Read the comment docs.

jcolomb commented 3 years ago

great improvement, you can merge if the last comment stands!

achilleas-k commented 3 years ago

Ok, fixed the line and added the commit. You can mark the PR ready for review?

jcolomb commented 3 years ago

oups, just realised I made change in the master directly while I wanted them in this branch... in the quickstart.md file, you may want to review that, too