G-Node / tonic

Framework for building services that interact with GIN
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

solve submodules issues #39

Closed jcolomb closed 1 year ago

jcolomb commented 3 years ago

Please use the review process to complete the debugging:

Issues with committing changes in the submodule or initiating gin. Currently using a workaround using the initiation scripts to add and push content to the created repositories (need ssh).

submodules cannot be pushed because they are no gin repo. We would need a way to push submodule content, something equivalent to git submodule for each gin init after creating them.

NB: since on gindata the link with ssh submodule do not work, we use relative links.

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (5592e71) into master (28dded2) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   57.59%   57.59%           
=======================================
  Files           8        8           
  Lines         474      474           
=======================================
  Hits          273      273           
  Misses        166      166           
  Partials       35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28dded2...5592e71. Read the comment docs.

jcolomb commented 3 years ago

doing manual editing locally and then pushing:

git submodule set-url 06_disseminations/02_manuscript "ssh://git@gindata.biologie.hu-berlin.de:10022/testtonic/test003_newcode.06_disseminations_02_manuscript.git" this works, but the link on gindata does not work because of the 10022 port issue

git submodule set-url 06_disseminations/02_manuscript "https://gindata.biologie.hu-berlin.de/testtonic/test003_newcode.06_disseminations_02_manuscript" This solves the link, but the repo is still empty and the sync scripts does not do anything.

Note: the folder is not a git folder locally ?? I needed to git init, commit stuff and git add remote in the folder itself. (once the remote is not empty anymore, git submodule init + git submodule update did work, needs the gin credential to work because it used https)

jcolomb commented 2 years ago

solved an issue with os-chdir not getting to the right folder, but it is still not working. Adding one submodule (labcommons) always worked, I forgot to commit the change before the push.

git submodule set-url: