search

G-Paris / kawapai

Python library for interfacing with Kawasaki D, E and F series controllers
6 stars 7 forks source link

Fixed a bug with the sequence number and with the motion parameters #3

Closed bambam01 closed 6 years ago

bambam01 commented 6 years ago

The sequence number was never checked because of a bug in the if statement and it was never reset The motion parameters where also never set because of the same bug in the if statement

gavanderhoorn commented 6 years ago

Just an fyi: the commit was not made with an email address recognised by GH. You may want to fix that before this PR gets merged.

G-Paris commented 6 years ago

Bambam has asked me to close this request so he can re-request with a recognized email address.

gavanderhoorn commented 6 years ago

For future reference: a local fixup of the commit followed by a force push to the same branch would also have worked.

gavanderhoorn commented 5 years ago

Ping? Is this PR going to be resubmitted?