G-Research / ParquetSharp

ParquetSharp is a .NET library for reading and writing Apache Parquet files.
Apache License 2.0
183 stars 49 forks source link

Run tests built against the previous stable release in CI #446

Closed adamreeve closed 6 months ago

adamreeve commented 6 months ago

This adds a CI job to run the tests built against the previous stable release with the current dll and native library at runtime, to try to detect binary compatibility issues like #443

I've also updated the logical type roundtrip tests so that they would catch the logical type enum values changing.

adamreeve commented 6 months ago

How about we try to checkout previous version (previous commit) to run the tests against current binary (binary built from the current commit)?

This is the idea. BASELINE_VERSION is the old stable version to checkout and build the tests for, and we then run those against the new ParquetSharp.dll from the NuGet that has been built in previous steps.

marcin-krystianc commented 6 months ago

How about we try to checkout previous version (previous commit) to run the tests against current binary (binary built from the current commit)?

This is the idea. BASELINE_VERSION is the old stable version to checkout and build the tests for, and we then run those against the new ParquetSharp.dll from the NuGet that has been built in previous steps.

Ah, I missed that!

adamreeve commented 6 months ago

Closing as I don't believe this is necessary after #449.