G-Research / fasttrackml

Experiment tracking server focused on speed and scalability
https://fasttrackml.io/
Apache License 2.0
98 stars 19 forks source link

Remove global var database.DB #273

Open suprjinx opened 1 year ago

suprjinx commented 1 year ago

database.ConnectDB() has the side-effect of setting a global variable to hold the DB connection instance. We should remove the dependence on the global var (I see 71 usages across 11 files), and then remove the ConnectDB function as well.

galadd commented 1 year ago

250 has refactored the whole DB Conn (no more database.ConnectDB()). Issue might need a new description if this is still a necessity