G-Research / geras

Geras provides a Thanos Store API for the OpenTSDB HTTP API. This makes it possible to query OpenTSDB via PromQL, through Thanos.
https://github.com/G-Research/geras
Apache License 2.0
38 stars 16 forks source link

Remove the goimport check #100

Closed greed42 closed 1 year ago

greed42 commented 1 year ago

For starters, the name is Check formatting and it does not check formatting. It checks imports.

But: The tool itself cannot cope with the golang.org/x/tools package: if you add the checksum it says via go mod download it then complains you need to go mod tidy, which then removes that checksum.

go: downloading golang.org/x/tools v0.0.0-20201201161351-ac6f37ff4c2a
go: updates to go.mod needed; to update it:
    go mod tidy

vs

missing go.sum entry for module providing package golang.org/x/tools/cmd/goimports; to add:
    go mod download golang.org/x/tools
eswdd commented 1 year ago

Lgtm, but also check failures