G-Research / geras

Geras provides a Thanos Store API for the OpenTSDB HTTP API. This makes it possible to query OpenTSDB via PromQL, through Thanos.
https://github.com/G-Research/geras
Apache License 2.0
38 stars 16 forks source link

Add -metrics-name-rewriting option to replace '.' with ':' #80

Closed dgl closed 4 years ago

dgl commented 4 years ago

Without this we do this for requests but not responses, which we got away with because Thanos doesn't validate the metric names as closely. But Prometheus remote_read doesn't allow '.', so always replace the name with the ':' version.

An option for now because this is confusing behaviour:

Fixes #79.

eswdd commented 4 years ago

Wondering if we can name the option to make it clear we're renaming on the response, as otherwise one might be forgiven for thinking that without it we don't rewrite "." to ":" when doing a name query