G-Research / geras

Geras provides a Thanos Store API for the OpenTSDB HTTP API. This makes it possible to query OpenTSDB via PromQL, through Thanos.
https://github.com/G-Research/geras
Apache License 2.0
38 stars 16 forks source link

Rewrite '-' in metrics to '_' to avoid remote read issues #85

Closed dgl closed 3 years ago

dgl commented 3 years ago

In general all this affects is what __name__ looks like on the returned data, as in nearly all cases the name gets changed by a recording rule anyway, it has very limited impact, the main thing would be legends on graphs (but I would be surprised if that broke anything) and complex label_replace()s.

If anything it's just confusing making this a flag, we can rollback if anyone has issues, but I really suspect there won't be.