search

G-Research / spark-dgraph-connector

A connector for Apache Spark and PySpark to Dgraph databases.
Apache License 2.0
43 stars 11 forks source link

Rename maxLeaseId to maxUid #221

Closed EnricoMi closed 1 year ago

EnricoMi commented 1 year ago

This renames maxLeaseId to maxUid as this has changed in Dgraph years ago.

github-actions[bot] commented 1 year ago

Test Results

  1 509 files  ±  0    1 509 suites  ±0   41m 18s :stopwatch: - 1m 7s      441 tests +  2       441 :heavy_check_mark: +  2  0 :zzz: ±0  0 :x: ±0  20 123 runs  +18  20 123 :heavy_check_mark: +18  0 :zzz: ±0  0 :x: ±0 

Results for commit b32c8838. ± Comparison against base commit b242e6ae.

This pull request removes 11 and adds 13 tests. Note that renamed tests count towards both. ``` python.test.test_api.ApiTest ‑ test_api_constant_MaxLeaseIdEstimatorOption uk.co.gresearch.spark.dgraph.connector.TestClusterState ‑ ClusterState should handle Json with no maxLeasId / maxUID uk.co.gresearch.spark.dgraph.connector.TestClusterState ‑ ClusterState should handle non-numeric maxLeaseIds uk.co.gresearch.spark.dgraph.connector.TestClusterState ‑ ClusterState should handle numeric maxLeaseIds uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxLeaseIdUidCardinalityEstimator should fail on negative or zero max uids uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxLeaseIdUidCardinalityEstimator with no maxLeaseId should estimate partition without uid range and uids uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxLeaseIdUidCardinalityEstimator with no maxLeaseId should estimate partition's uid range uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxLeaseIdUidCardinalityEstimator with no maxLeaseId should estimate partition's uids cardinality uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxLeaseIdUidCardinalityEstimator with some maxLeaseId should estimate partition without uid range and uids uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxLeaseIdUidCardinalityEstimator with some maxLeaseId should estimate partition's uid range … ``` ``` python.test.test_api.ApiTest ‑ test_api_constant_MaxUidEstimatorOption python.test.test_api.ApiTest ‑ test_api_constant_UidRangePartitionerMaxPartsDefault python.test.test_api.ApiTest ‑ test_api_constant_UidRangePartitionerMaxPartsOption uk.co.gresearch.spark.dgraph.connector.TestClusterState ‑ ClusterState should handle Json with no maxLeaseId / maxUID uk.co.gresearch.spark.dgraph.connector.TestClusterState ‑ ClusterState should handle non-numeric unsigned longs uk.co.gresearch.spark.dgraph.connector.TestClusterState ‑ ClusterState should handle numeric unsigned longs uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxUidUidCardinalityEstimator should fail on negative or zero max uids uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxUidUidCardinalityEstimator with no maxUid should estimate partition without uid range and uids uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxUidUidCardinalityEstimator with no maxUid should estimate partition's uid range uk.co.gresearch.spark.dgraph.connector.partitioner.TestUidCardinalityEstimator ‑ MaxUidUidCardinalityEstimator with no maxUid should estimate partition's uids cardinality … ```

:recycle: This comment has been updated with latest results.