G-Two / homeassistant-subaru

Subaru STARLINK custom component for Home Assistant.
Apache License 2.0
54 stars 7 forks source link

Dismiss persistent notifications #20

Closed ACiDGRiM closed 2 years ago

ACiDGRiM commented 2 years ago

I personally would prefer to not have a notification every time I call a Subaru service. I've looked though your code and can only tell that the notification ID is assigned the DOMAIN variable. I'm not a developer and can't identify where the value of DOMAIN is pulled from to call persistent_notification.dismiss

Can you please give me some information or if this is a possible use case for this integration, allow the notifications to be disabled unless there's an error message.

All said, this is by far the most functional integration in all of HA. Thank you.

G-Two commented 2 years ago

@ACiDGRiM DOMAIN is imported from const.py and has the value "subaru". I think your use case makes sense, in the next release I'll add an option to disable notifications of successful remote commands. Thanks for the feedback!