G-Two / homeassistant-subaru

Subaru STARLINK custom component for Home Assistant.
Apache License 2.0
54 stars 6 forks source link

v0.6.0 #36

Closed G-Two closed 2 years ago

G-Two commented 2 years ago

Breaking Changes

New Features

Miscellaneous

Related Issues

stboch commented 2 years ago

Remote Start working properly on 2020 Outback

ACiDGRiM commented 2 years ago

Remote Start with Climate Preset working on 2019 Ascent.

stboch commented 2 years ago

@G-Two Not sure exactly what the issue is as it seems to only be happening with "Selects" but one car is properly creating the Select however one of the other is not... I added a bunch of debug it looks like it never enters the options property for the class.

2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru] Finished fetching subaru_data data in 31.001 seconds (success: True) 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] Creating selects for 4S4BTAPC9XXXXXX and is RES True 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] Entering Successful if for 4S4BTAPC9XXXXXXX 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] init of Climate class 4S4BTAPC9XXXXXX 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] Creating selects for 4S4WMARD6XXXXXX and is RES True 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] Entering Successful if for 4S4WMARD6XXXXXX 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] init of Climate class 4S4WMARD6XXXXXX 2021-12-29 11:55:55 DEBUG (MainThread) [custom_components.subaru.select] Getting 4S4WMARD6XXXXXX climate data.

G-Two commented 2 years ago

@stboch I'll probably need debug logs from subarulink to figure out the cause

stboch commented 2 years ago

@G-Two I didn't include subarulink logs because the issue isn't the subaru side it seems like something with homeassistant.

G-Two commented 2 years ago

@stboch are the settings entities for both vehicles created?

stboch commented 2 years ago

@G-Two yeah, after finding the NULL presets bug I added a preset to move past it, and thats where it is only creating the select for one of the two cars. There doesn't seem to be anything specific about it thats why I added a bunch of debug to make sure it was following through the functions, but ultimately it seems like it initializes the car but doesn't enter into the defining the selects options.

But remote start service and everything still works, and when forcing the code to enter the climate function i get the data from subarulink for the car.

G-Two commented 2 years ago

@stboch can you paste your modified select.py (with the additional debug lines) so I can see where in the code the debug trace maps to? It's still not clear to me whether or not the second entity is created (just without any options to select from).

stboch commented 2 years ago

@G-Two https://gist.github.com/stboch/4f6acbb9588432de3d8d32ba0d8429d9

G-Two commented 2 years ago

Ok I see the problem in async_setup_entry. climate_select needs to be its own list and each new entity needs to be appended to it. Otherwise only the last vehicle will be added to hass. It’ll be any easy fix.

stboch commented 2 years ago

Looks great over here. New fixes working perfectly.

FerriteGiant commented 2 years ago

Remote Start is working on my 2019 Forester. The sunroof binary sensor doesn't show up for me.