G-Two / homeassistant-subaru

Subaru STARLINK custom component for Home Assistant.
Apache License 2.0
54 stars 7 forks source link

Subaru.fetch and Subaru.update - Description Mismatch #40

Closed mpogue1996 closed 8 months ago

mpogue1996 commented 2 years ago

If you check the services that run on the Lovelace UI buttons "Update" and "Poll Vehicle", and verify them against the services that they call (Subaru.update and Subaru.fetch), you'll notice that the descriptions for these services are actually swapped.

The Subaru.fetch service does actually poll the vehicle.

G-Two commented 2 years ago

I'm not sure I understand where the issue is. Is this with the newly implemented buttons in the prerelease? Please reference the specific file in the repo where you found the description mismatch.

ACiDGRiM commented 2 years ago

I think mpogue1996 should move his automations to use the button press entities

However, it appears that the button.refresh only does the fetch (pulls latest data) and a button.update (asks the car for the latest data) does not exist.

G-Two commented 2 years ago

I thought fetch and update were too similar sounding, so with the v0.6.0 buttons I named them refresh and locate. The old subaru.update service simply issued a remote locate command, which also resulted in new sensor data being sent by the vehicle with the location.

In short:

subaru.fetch has never polled the vehicle, so if there's an error in the code or a description anywhere, I'd like to fix it.

ACiDGRiM commented 2 years ago

Good to know that the locate button does the polling. I do think that seems a bit un-selfexplanitory, however I can't think of a better name other than button.poll. But my major issues are all solved, I can't reproduce any issues the original user reported.

Mark612 commented 2 years ago

I agree, this is confusing. I think refresh should do a poll and the updated sensor data. Fetch should be a different icon, calendar or date maybe.

G-Two commented 8 months ago

Resolved with v0.7.0