search

G-Two / subarulink

A python package for interacting with Subaru STARLINK remote vehicle services.
Apache License 2.0
84 stars 14 forks source link

Error on door unlock #49

Closed Derekzielinski closed 2 years ago

Derekzielinski commented 2 years ago

On v0.6.0rc2, I get this error when unlocking the doors. Locking works fine. This is directly from the subaru lock entity.

Service unlock failed for _insert_VINhere: Invalid door 'all' specified for unlock command.

Screen Shot 2021-12-30 at 9 40 38 AM
G-Two commented 2 years ago

Thank you for reporting that. I made a dumb mistake here:

    async def async_unlock(self, **kwargs):
        """Send the unlock command."""
        _LOGGER.debug("Unlocking doors for: %s", self.car_name)
        await async_call_remote_service(
            self.hass,
            self.controller,
            SERVICE_UNLOCK,
            self.vehicle_info,
            UNLOCK_DOOR_ALL, # this should be UNLOCK_VALID_DOORS[UNLOCK_DOOR_ALL],
            self.config_entry.options.get(CONF_NOTIFICATION_OPTION),
        )

I'll fix in rc3

Derekzielinski commented 2 years ago

Working in rc3. Thanks for the quick fix, and for all your work on this!