search

G-Two / subarulink

A python package for interacting with Subaru STARLINK remote vehicle services.
Apache License 2.0
86 stars 13 forks source link

[CLI Feature Request] Choose climate preset in `subarulink remote_start` instead of always using default #93

Closed a4v2d4 closed 8 months ago

a4v2d4 commented 8 months ago

Background: Currently, the remote_start CLI option always start w/ default preset. I want to choose the climate preset based on my local weather via simple bash script that i run through iOS shortcuts.

Request: add optional additional argument for remote_start to choose climate preset by name e.g. subarulink remote_start [climate_preset_name]

a4v2d4 commented 8 months ago

I've made this change in my forked repo: https://github.com/deltatxv/subarulink

@G-Two Lmk if you want me to create a PR for this - I'll clean up some of the code and commits.

G-Two commented 8 months ago

I tested the new feature and it works great on my end. Please create a PR. Thanks for adding this!

a4v2d4 commented 8 months ago

Thanks for making this tool!

PR here: https://github.com/G-Two/subarulink/pull/94