search

G-U-N / Be-Your-Outpainter

[ECCV 2024] Be-Your-Outpainter https://arxiv.org/abs/2403.13745
https://be-your-outpainter.github.io
219 stars 8 forks source link

Bugs for is_gird=True #8

Open mmmmm-w opened 4 months ago

mmmmm-w commented 4 months ago

When turn on is_grid, errors happen.

In pipelineoutpaint.py line 795, should change [..., :height,:, :] to [..., :height, :]. In pipelineoutpaint.py line 815, should change text_embeddings to text_embeddings["text_embedding"]

G-U-N commented 4 months ago

Would you mind making a Pull requests?

mmmmm-w commented 4 months ago

Can you provide more details about prompt-conditioned out-painting? So far I haven't get it done by setting is_grid=True, even after fixing some bugs. Thanks!

stanathong commented 4 months ago

I also noticed some part of the code that refers to the setting of is_grid to True. However, I can't really find anything relevant to this in the paper. Could anyone point this out to me please?

Are the outpainting results presented in the paper are created with is_grid = True? By setting is_grid = True, do we expect the results to be sorts of better than not?

Thank you.

G-U-N commented 4 months ago

This setting was not used in the paper or the primary experiments. It is my preliminary exploration.

stanathong commented 4 months ago

Thanks for your prompt response.