search

G-dH / custom-hot-corners-extended

A GNOME Shell Extension that allows you to give a function to any corner or edge of your monitors and expand your keyboard capabilities.
GNU General Public License v3.0
130 stars 19 forks source link

GNOME 45 support #78

Closed GerryT11 closed 9 months ago

GerryT11 commented 1 year ago

There are breaking changes which will require a separate extension release for Gnome 45 and <=44:

See Gnome 45 porting guide: https://gjs.guide/extensions/upgrading/gnome-shell-45.html

FYI, here is lots of information on the changes in Gnome 45 for extensions: https://blogs.gnome.org/shell-dev/2023/09/02/extensions-in-gnome-45/ . For early testing, they mention "You can test your extensions by downloading the latest GNOME OS and trying your extension there."

G-dH commented 1 year ago

You can help me with testing:

Installation instructions for GNOME 45

GerryT11 commented 1 year ago

You can help me with testing:

Installation instructions for GNOME 45

Sorry, so far I was not yet able to successfully run GnomeOS in Gnome-Boxes to test the extension. I hope someone else helps you with testing, too!

G-dH commented 1 year ago

@GerryT11 Boxes and GNOME OS never worked well on my system, I'm testing on Fedora Rawhide and 39 in VirtualBox.

LostinSpacetime commented 1 year ago

You can help me with testing:

Installation instructions for GNOME 45

I tested with Fedora 39 in VMware and so far, it worked perfectly. The only issue is that it works only with ”Use fallback hot corner triggers” but I believe it's because of how VMware handles mouse input.

G-dH commented 1 year ago

@LostinSpacetime Thanks! Hot corners can't work inside the virtual machine if mouse integration is enabled.

LostinSpacetime commented 1 year ago

I disabled the automatic mouse grabbing/releasing by adding mks.gamingMouse.policy = "gaming" to the vm. The mouse stays now locked within the guest window, but even like this only the fallback trigger works.

G-dH commented 1 year ago

I don't use VMware so I can't say, but it works as expected inside the VirtualBox.

LostinSpacetime commented 1 year ago

This is what I get when I disable the Extension:

Main.layoutManager._updateHotCorners is not a function

After a restart, the Gnome native active corner works as expected.

G-dH commented 1 year ago

Thanks, I'll look into it.

G-dH commented 12 months ago

Main.layoutManager._updateHotCorners is not a function

Should be fixed.

LostinSpacetime commented 12 months ago

The error is gone, and I also tested within VirtualBox. The extension is working, as far as I can tell. It seems the problem I have is VMware related.

Thank you!

belarios commented 11 months ago

Mostly working for me on arch linux, gnome 45.0.

Pressure barrier sensitivity changed somehow. I used to have them at 100, but with the esm branch that didn't work at all. Took me a while to figure out that I had to move them down below 20 to get them to be responsive.

I've had one gnome-shell crash so far while pressing the side of the screen. Will update if it happens again.

Thanks.

G-dH commented 11 months ago

@belarios Nothing has changed in the CHC-E in this regard, and the hot corner triggers work the same for me on the GS 45 with the same pressure setting as the 44, so the difference must be somewhere else..

mlmilliman commented 11 months ago

Main.layoutManager._updateHotCorners is not a function

Should be fixed.

I'm still receiving this error with GNOME 45 on Ubuntu.

marekzan commented 11 months ago

Mostly working for me on arch linux, gnome 45.0.

Pressure barrier sensitivity changed somehow. I used to have them at 100, but with the esm branch that didn't work at all. Took me a while to figure out that I had to move them down below 20 to get them to be responsive.

I've had one gnome-shell crash so far while pressing the side of the screen. Will update if it happens again.

Thanks.

I have the same issue. I had to lower the sesitivity below 20. On my machine the sweet spot is at about 10.

G-dH commented 11 months ago

@marekzan Thanks, I'll look into it. Can you please try, for example, the Hot Edge extension to see whether it has the same issue?

marekzan commented 11 months ago

I just tried the Hot Edge extension and it worked with its defaults.

Activation Pressure: 150 Edge Size: 100

G-dH commented 11 months ago

@marekzan , @belarios I missed a reference to the unexported HOT_CORNER_PRESSURE_TIMEOUT constant. Can you please try the latest update?

marekzan commented 11 months ago

I tried the latest update and can confirm that it fixed the issue for me. Thank you very much for your effort!

FelixFourcolor commented 11 months ago

I tried on Arch. Everything seems to work.

FelixFourcolor commented 11 months ago

@G-dH Is there any reason you haven't published this to EGO? Not that I have any problem with the git version, I'm just curious.

G-dH commented 11 months ago

@FelixFourcolor One reason is my free time and the other is the fact that CHC-E breaks the new EGO rules that affect actions creating screen/window effects and objects that must survive screen lock.