G-dH / vertical-workspaces

V-Shell is a GNOME Shell extension that allows you to customize the layout and behavior of the Shell UI.
GNU General Public License v3.0
229 stars 19 forks source link

[BUG] Dot is offcenter #150

Closed axkibe closed 3 months ago

axkibe commented 5 months ago

Describe the bug The dot is off center

https://imgur.com/Blmf1Di

This is an extreme OCD issue :)

System:

System log output open terminal, execute: journalctl /usr/bin/{gjs,gnome-shell} -fo cat

reproduce the bug, copy the output from terminal if any. AdwToolbarView 0x5669ff486c00 exceeds AdwBreakpointBin width: requested 846 px, 840 px available AdwToolbarView 0x5669ff486c00 exceeds AdwBreakpointBin width: requested 846 px, 840 px available AdwToolbarView 0x5669ff486c00 exceeds AdwBreakpointBin width: requested 846 px, 840 px available AdwToolbarView 0x5669ff486c00 exceeds AdwBreakpointBin width: requested 846 px, 840 px available AdwToolbarView 0x5669ff486c00 exceeds AdwBreakpointBin width: requested 846 px, 840 px available AdwToolbarView 0x5669ff486c00 exceeds AdwBreakpointBin width: requested 846 px, 840 px available meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed Unhandled promise rejection. To suppress this warning, add an error handler to your promise chain with .catch() or a try-catch block around your await expression. Stack trace of the failed promise: _promisify/proto[asyncFunc]@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:448:16 openExtensionPrefs@resource:///org/gnome/shell/ui/extensionSystem.js:321:26 OpenExtensionPrefs@resource:///org/gnome/shell/ui/shellDBus.js:465:31 LaunchExtensionPrefs@resource:///org/gnome/shell/ui/shellDBus.js:461:14 _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:329:38 _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34 @resource:///org/gnome/shell/ui/init.js:21:20

Custom Hot Corners - Extended: disabled Custom Hot Corners - Extended: enabled

PS: I just recently had to disable Dash-To-Dock due black screen after login and thats why I just installed git version instead. But no issue here honestly right I jsut wonder why I needed it at all. Last two lines, I just made sure my "no other extension" remark is true.

G-dH commented 5 months ago

I'm not sure I understand. Is the issue related to the version installed from the GitHub or not?

axkibe commented 5 months ago

Yes, its the github version. Main. About of the exctension says 46.1

G-dH commented 5 months ago

Thanks. Fixed.

axkibe commented 5 months ago

Thanks now I can sleep sound again knowing the dots would be centered if I would turn on my laptop.

axkibe commented 5 months ago

btw, is there a possibility to move the dot a bit more left? I see the margin to the box is already 0, naivly I tried "position: relative; left: -4px;" in the stylesheet, but realized this is gtk3 css not "real" css..

G-dH commented 5 months ago

If you move it, it will be placed outside the icon widget. It is possible using the translation_x property of the dot widget. You can try it from the Looking Glass (Alt+F2 -> lg -> Enter):

Main.overview.dash._box.get_children().forEach(i => i.child?._dot.set_translation(-5, 0, 0))

The dot size is 5px.

axkibe commented 4 months ago

Thank you, I tried it, I was wrong, it looks more ugly that way.

ea-ooe commented 4 months ago

Hi, this issue is fixed for gnome-shell 46.1, but reoccurs after upgrading to gnome-shell 46.2 using version 46.2/62 of the extension. image

G-dH commented 4 months ago

@ea-ooe : Thanks, GNOME developers couldn't decide whether to adjust the indicator position in the code or in CSS. I'll fix it.