[BUG] Scrolling to the wrong page after dragging an icon from a folder to a specific page

[meybonomme]

If I simply drag the icon out of the folder, it is set as the last icon and the app grid scrolls to that page to show the newly dragged icon. When I drag the icon to a specific page, it drops to the right place, but the app grid scrolls itself to the first page.

https://github.com/G-dH/vertical-workspaces/assets/147217565/36c3d346-5d27-4e6e-905f-04032467bb35

[G-dH]

Can you reproduce this issue using the mouse?

[meybonomme]

I used a mouse when I did this screencast.

[G-dH]

So the issue is that the grid switches back to the page with the folder.

[G-dH]

Fixed, except for the last item in the folder.

[meybonomme]

https://github.com/G-dH/vertical-workspaces/assets/147217565/4c12e5b7-d4f6-425f-ab60-eaa40d11b4b7

Fixed, except for the last item in the folder.

My quick test showed that it works with last item in the folder too.

[G-dH]

When there is only one item in the folder and you drag it out to a specific place in the main grid, it will be placed as the last item in the grid instead of the chosen place. However, It will be focused correctly.

[G-dH]

So this bug can be labeled as fixed.

[meybonomme]

So this bug can be labeled as fixed.

Did you watch my last posted screencast with overlapping icons?

[G-dH]

?

[meybonomme]

https://github.com/G-dH/vertical-workspaces/assets/147217565/eb9092aa-dae2-4f7f-8684-6ee0f04d502f

[G-dH]

But that's a different bug, right?

[meybonomme]

This happened after yesterday's update.

[G-dH]

The yesterday's commit doesn't include changes that could cause this. In any case, it's a different issue.

[meybonomme]

Is this another upstream bug? Should I start a new issue?

[meybonomme]

So this bug can be labeled as fixed.

Yes, the bug for this issue has been fixed.

[G-dH]

When there is only one item in the folder and you drag it out to a specific place in the main grid, it will be placed as the last item in the grid instead of the chosen place. However, It will be focused correctly.

This bug is now fixed.

[meybonomme]

I installed the updates and all the DnD related issues seem to be gone now.

Are just the page dots now too close to the dock again, or has the entire app grid shifted down? I don't understand exactly. Screenshots with laptop monitor and external monitor:

[meybonomme]

I didn't open a new issue because this bug appeared after the last DnD fixes. When opening the folder, it is easy to see that not only the dots, but the entire application grid has shifted too far down:

[G-dH]

It's the missing margin of DtD, which the default dash has. Will be fixed in the next update.

[G-dH]

I've refactored all overview allocations, please let me know how it works for you.

[meybonomme]

Using adaptive rows per page, with internal monitor main app grid looks very fine. 1920x1080 and 100% scaling:

External monitor with 2560x1440 and 125% scaling have now only 4 rows instead of 5. It looks too empty and impractical room wasting:

Folder content looks bit out of a place. Page dots are too close to folder bottom edge and the app grid also seems too close to the bottom edge:

[meybonomme]

If I set folder rows per page from adaptive to 5 or more, folder have still only 4 rows.

[G-dH]

Please, open a new issue for every new bug.

[G-dH]

External monitor with 2560x1440 and 125% scaling have now only 4 rows instead of 5. It looks too empty and impractical room wasting

Have you set the page height to max?

The difference between those two resolutions recalculated for the used scale factor is less than a size needed for a new row of icons, so the empty space increases.

[meybonomme]

Have you set the page height to max?

My mistake, I missed this setting. Since you changed the algorithm for calculating the scale factor, I only had to change the App Grid Page Height Scale from 90 to 95.

I've refactored all overview allocations, please let me know how it works for you.

Overly it works fine.

Please, open a new issue for every new bug.

I understand, otherwise it will be difficult for you to track known bugs. I will open new issues.

[meybonomme]

I feel like this issue can be closed since the original issue is nicely resolved.