G-dH / vertical-workspaces

V-Shell is a GNOME Shell extension that allows you to customize the layout and behavior of the Shell UI.
GNU General Public License v3.0
231 stars 20 forks source link

[BUG] Overview animation randomly will not play when triggered. #182

Open nsurvance opened 4 months ago

nsurvance commented 4 months ago

I've run into an issue where on 2nd+ work spaces, the overview animation will occasionally not play. It happens at random, and works correctly 50% of the time.

https://github.com/G-dH/vertical-workspaces/assets/58082491/51566376-6744-4342-b3e1-3abec17c8279

One 3rd+ work spaces, the desktop will clip into the dock in the overview as well. I have tried disabling any extensions that might interact with the desktop/overview, and nothing seemed to fix the issue.

Screenshot from 2024-07-09 17-37-28

System: Fedora Workstation 40 Version 65 Installed from Gnome Extensions

Other Extensions Enabled: AppIndicator and KStatusNotifierItem Support Blur my Shell Caffeine Hot Edge Luminus Shell Y Tiling Shell Week Start Modifier

G-dH commented 4 months ago

Please, disable all other extensions, restart Shell and try to reproduce the issue. Show me your configuration, upload the output file of the following command: dconf dump /org/gnome/shell/extensions/vertical-workspaces/ > vw_config.txt

With V-Shell you don't need Hot Edge extension, it's built-in as the Hot Corner Position > Follow Dash - Hot Edge option. Blur My Shell overview/app grid blur may be in conflict with V-Shell.

nsurvance commented 4 months ago

I did as you said and turned off the other extensions and restarted the session, but it does not seem to affect the issue.

https://github.com/G-dH/vertical-workspaces/assets/58082491/a9cb2c85-5797-4b49-859b-5a16d2078b37

dconf dump:

aaa-loading-profile=false
always-activate-selected-window=false
animation-speed-factor=100
app-display-module=true
app-favorites-module=true
app-folder-order=0
app-grid-active-preview=false
app-grid-animation=4
app-grid-bg-blur-sigma=40
app-grid-columns=8
app-grid-content=2
app-grid-folder-center=true
app-grid-folder-columns=3
app-grid-folder-icon-grid=4
app-grid-folder-icon-size=-1
app-grid-folder-rows=3
app-grid-folder-spacing=12
app-grid-icon-size=96
app-grid-incomplete-pages=true
app-grid-names=0
app-grid-order=0
app-grid-page-height-scale=65
app-grid-page-width-scale=80
app-grid-performance=true
app-grid-rows=3
app-grid-spacing=30
center-app-grid=true
center-dash-to-ws=false
center-search=true
click-empty-close=true
close-ws-button-mode=1
dash-bg-color=0
dash-bg-gs3-style=false
dash-bg-opacity=100
dash-bg-radius=24
dash-icon-scroll=1
dash-isolate-workspaces=false
dash-max-icon-size=64
dash-module=true
dash-position=2
dash-position-adjust=0
dash-show-windows-before-activation=1
delay-startup=false
enable-page-shortcuts=true
favorites-notify=1
highlighting-style=0
hot-corner-action=1
hot-corner-fullscreen=true
hot-corner-position=6
hot-corner-ripples=true
layout-module=false
message-tray-module=false
new-window-focus-fix=false
new-window-monitor-fix=false
notification-position=2
osd-position=6
osd-window-module=false
overlay-key-module=true
overlay-key-primary=1
overlay-key-secondary=1
overview-bg-blur-sigma=40
overview-bg-brightness=60
overview-esc-behavior=0
overview-mode=0
panel-module=false
panel-position=0
panel-visibility=0
profile-data-2={'workspaceThumbnailsPosition': '0', 'wsMaxSpacing': '350', 'wsPreviewScale': '100', 'secWsPreviewScale': '100', 'secWsPreviewShift': 'false', 'wsThumbnailsFull': 'true', 'secWsThumbnailsPosition': '2', 'dashPosition': '2', 'dashPositionAdjust': '0', 'wsTmbPositionAdjust': '0', 'showWsTmbLabels': '0', 'showWsTmbLabelsOnHover': 'false', 'closeWsButtonMode': '1', 'secWsTmbPositionAdjust': '0', 'dashMaxIconSize': '64', 'centerDashToWs': 'false', 'showAppsIconPosition': '1', 'wsThumbnailScale': '13', 'wsThumbnailScaleAppGrid': '13', 'secWsThumbnailScale': '13', 'showSearchEntry': 'true', 'centerSearch': 'true', 'centerAppGrid': 'true', 'dashBgOpacity': '100', 'dashBgColor': '0', 'dashBgRadius': '24', 'dashBgGS3Style': 'false', 'runningDotStyle': '0', 'enablePageShortcuts': 'true', 'showWsSwitcherBg': 'false', 'showWsPreviewBg': 'true', 'wsPreviewBgRadius': '21', 'showBgInOverview': 'true', 'overviewBgBrightness': '60', 'searchBgBrightness': '30', 'overviewBgBlurSigma': '40', 'appGridBgBlurSigma': '40', 'smoothBlurTransitions': 'true', 'appGridAnimation': '4', 'searchViewAnimation': '0', 'workspaceAnimation': '1', 'animationSpeedFactor': '100', 'winPreviewIconSize': '0', 'winTitlePosition': '2', 'startupState': '0', 'overviewMode': '0', 'workspaceSwitcherAnimation': '1', 'wsSwitcherMode': '0', 'searchIconSize': '96', 'searchViewScale': '100', 'appGridIconSize': '96', 'appGridColumns': '8', 'appGridRows': '3', 'appGridFolderIconSize': '-1', 'appGridFolderColumns': '3', 'appGridFolderRows': '3', 'appGridFolderIconGrid': '3', 'appGridContent': '2', 'appGridIncompletePages': 'true', 'appGridOrder': '0', 'appFolderOrder': '0', 'appGridNamesMode': '0', 'appGridActivePreview': 'false', 'appGridFolderCenter': 'true', 'appGridPageWidthScale': '80', 'appGridPageHeightScale': '65', 'appGridSpacing': '30', 'appGridFolderSpacing': '12', 'searchWindowsOrder': '1', 'searchFuzzy': 'true', 'searchMaxResultsRows': '5', 'dashShowWindowsBeforeActivation': '1', 'dashIconScroll': '1', 'dashIsolateWorkspaces': 'false', 'searchWindowsIconScroll': '1', 'panelVisibility': '0', 'panelPosition': '0', 'windowAttentionMode': '0', 'wsSwPopupHPosition': '50', 'wsSwPopupVPosition': '95', 'wsSwPopupMode': '1', 'wsSwitcherWraparound': 'false', 'wsSwitcherIgnoreLast': 'false', 'favoritesNotify': '1', 'notificationPosition': '2', 'osdPosition': '6', 'hotCornerAction': '1', 'hotCornerPosition': '0', 'hotCornerFullscreen': 'true', 'hotCornerRipples': 'true', 'alwaysActivateSelectedWindow': 'false', 'winPreviewSecBtnAction': '3', 'winPreviewMidBtnAction': '0', 'winPreviewShowCloseButton': 'true', 'windowIconClickAction': '1', 'overlayKeyPrimary': '1', 'overlayKeySecondary': '1', 'overviewEscBehavior': '0', 'clickEmptyClose': 'true', 'newWindowFocusFix': 'false', 'newWindowMonitorFix': 'false', 'appGridPerformance': 'true', 'highlightingStyle': '0', 'delayStartup': 'false', 'workspaceSwitcherPopupModule': 'false', 'workspaceAnimationModule': 'false', 'workspaceModule': 'true', 'windowManagerModule': 'true', 'windowPreviewModule': 'true', 'windowAttentionHandlerModule': 'false', 'swipeTrackerModule': 'false', 'searchControllerModule': 'true', 'searchModule': 'true', 'panelModule': 'false', 'overlayKeyModule': 'true', 'osdWindowModule': 'false', 'messageTrayModule': 'false', 'layoutModule': 'false', 'dashModule': 'true', 'appFavoritesModule': 'true', 'appDisplayModule': 'true'}
profile-name-1='GNOME 3'
profile-name-3='Hot Corner Centric - Top Left Hot Corner'
profile-name-4='Dock Overview - Bottom Hot Edge'
running-dot-style=0
search-bg-brightness=30
search-controller-module=true
search-fuzzy=true
search-icon-size=96
search-max-results-rows=5
search-module=true
search-view-animation=0
search-width-scale=100
search-windows-icon-scroll=1
search-windows-order=1
sec-wst-position-adjust=0
secondary-ws-preview-scale=100
secondary-ws-preview-shift=false
secondary-ws-thumbnail-scale=13
secondary-ws-thumbnails-position=2
show-app-icon-position=1
show-bg-in-overview=true
show-search-entry=true
show-ws-preview-bg=true
show-ws-switcher-bg=false
show-wst-labels=0
show-wst-labels-on-hover=false
smooth-blur-transitions=true
startup-state=0
swipe-tracker-module=false
win-attention-handler-module=false
win-preview-icon-size=0
win-preview-mid-mouse-btn-action=0
win-preview-sec-mouse-btn-action=3
win-preview-show-close-button=true
win-title-position=2
window-attention-mode=0
window-icon-click-action=0
window-manager-module=true
window-preview-module=true
workspace-animation=1
workspace-animation-module=false
workspace-module=true
workspace-switcher-animation=1
workspace-switcher-popup-module=false
ws-max-spacing=350
ws-preview-bg-radius=21
ws-preview-scale=100
ws-sw-popup-h-position=50
ws-sw-popup-mode=1
ws-sw-popup-v-position=95
ws-switcher-ignore-last=false
ws-switcher-mode=0
ws-switcher-wraparound=false
ws-thumbnail-scale=13
ws-thumbnail-scale-appgrid=13
ws-thumbnails-full=true
ws-thumbnails-position=0
wst-position-adjust=0
G-dH commented 4 months ago

Can you try other predefined V-Shell profiles if it make any difference? Btw, are you sure that all other extensions were disabled?

nsurvance commented 4 months ago

I had missed the Fedora Background Logo extension in that video, but aside from that, I had disabled all extensions in extension manager. I did try it one more time (no extensions, new session) to make sure I did it correctly, and I still had the issue.

I tried switching to the "Hot Corner Centric - Top Left Hot Corner" profile, and the problem seemed to stop temporarily. Setting it back to my own profile causes the problem to reappear.

Edit: I extracted this line from `journalctl /usr/bin/gnome-shell'. Perhaps it is relevant

Jul 11 01:52:53 fedora gnome-shell[45234]: Can't update stage views actor unnamed [StBin] is on because it needs an allocation.
Jul 11 01:54:03 fedora gnome-shell[45234]: value "nan" of type 'gdouble' is invalid or out of range for property 'value' of type 'gdouble'
nsurvance commented 4 months ago

I seemed to have solved the issue, although I'm not sure exactly what is happening. I had disabled "WorkspaceAnimation" in the modules page, since it was labeled "Static workspace animation option," and I had assumed that it was the toggle to disable the static background when switching work spaces. It did actually do what I expected it to, but of course that's likely why the animations randomly don't play, I think? image Enabling it again fixed the issue, but now it leaves me confused as to why the animations still play on the first workspace when disabled, and about 50% of the time on consecutive work spaces. Or why disabling it causes the overview to clip into the dash. It's all over my head, it but it seems the issue has been resolved!

https://github.com/G-dH/vertical-workspaces/assets/58082491/2b5ef4a7-9e96-4de9-919c-ce92f7715865

nsurvance commented 4 months ago

Apologies for double closing this. I don't use Github often.

G-dH commented 4 months ago

Thanks. However, if there's a combination of settings that causes this behavior, it is still a bug. Generally, you don't need to disable V-Shell modules, use default options in settings instead.

nsurvance commented 4 months ago

Thanks, will do. If I can do anything else to help troubleshoot this, I would be happy too.