G-dH / vertical-workspaces

V-Shell is a GNOME Shell extension that allows you to customize the layout and behavior of the Shell UI.
GNU General Public License v3.0
231 stars 20 forks source link

[BUG] Cannot open folders from the AppGrid after the Gnome 47 update #195

Closed italoghost closed 2 months ago

italoghost commented 2 months ago

Describe the bug I cannot open folders from the AppGrid after the Gnome 47 update. I tried using the latest git, but it didn't work either.

Basic debug information

To Reproduce Steps to reproduce the behavior:

  1. Go to AppGrid
  2. Click on a folder.
  3. It won't open.

Expected behavior The folders should open when I click on them.

Screenshots N/A.

System:

System log output open terminal, execute: journalctl /usr/bin/{gjs,gnome-shell} -fo cat reproduce the bug, copy the output from terminal if any.

clutter_actor_add_child: assertion 'child->priv->parent == NULL' failed
JS ERROR: TypeError: this._removePopdownTimeout() is undefined
after__init@file:///home/ghost/.local/share/gnome-shell/extensions/vertical-workspaces@G-dH.github.com/lib/appDisplay.js:1372:38
overrideProto/proto[actualSymbol]@file:///home/ghost/.local/share/gnome-shell/extensions/vertical-workspaces@G-dH.github.com/lib/util.js:90:29
AppFolderDialog@resource:///org/gnome/shell/ui/appDisplay.js:2493:4
_ensureFolderDialog@resource:///org/gnome/shell/ui/appDisplay.js:2466:28
open/<@file:///home/ghost/.local/share/gnome-shell/extensions/vertical-workspaces@G-dH.github.com/lib/appDisplay.js:1103:18
@resource:///org/gnome/shell/ui/init.js:21:20
G-dH commented 2 months ago

Thanks, typo. Can you please test the latest update from this repository?

italoghost commented 2 months ago

Hi! It now open but it does not show the icons!

image

Another thing is that the AppGrid seems to be misaligned to the bottom of the screen:

image

italoghost commented 2 months ago

Log:

Can't update stage views actor unnamed [StWidget] is on because it needs an allocation.
Can't update stage views actor unnamed [Gjs_ui_iconGrid_BaseIcon] is on because it needs an allocation.
Can't update stage views actor unnamed [StBoxLayout] is on because it needs an allocation.
Can't update stage views actor unnamed [StBin] is on because it needs an allocation.
Can't update stage views actor unnamed [StIcon] is on because it needs an allocation.
Can't update stage views actor unnamed [ClutterActor] is on because it needs an allocation.
Can't update stage views actor unnamed [StLabel] is on because it needs an allocation.
Can't update stage views actor unnamed [ClutterText] is on because it needs an allocation.
Can't update stage views actor unnamed [Gjs_ui_appDisplay_AppIcon] is on because it needs an allocation.
italoghost commented 2 months ago

Ops, changing the icon size to 128 seems to have resolved the issue (it was set to Adaptive before).

image

image

italoghost commented 2 months ago

Regarding the AppGrid being misaligned to the bottom of the screen, it was the height scale. I adjusted that and it is now ok!

G-dH commented 2 months ago

Thanks. There is still some problem with folders in 47, I must have missed something in the GS commits...

KSTRTK commented 2 months ago

Hello, I'm experiencing something I believe is related, the v-shell seems to be only supported on gnome 46, and not 47.. is there an expectation to have it supported on 47? Thanks in advance!

**EDIT***

Was able to get it to work.

G-dH commented 2 months ago

@KSTRTK How did you get it to work?

I wasn't able to reproduce this issue today on Fedora.

KSTRTK commented 2 months ago

EDIT

I'm using EndeavorOS, just fyi

@G-dH I went to add/remove software (after installing pamac) and searched for this extension. After installing it, it worked just fine for me. I think it maybe something related to syncing via git? Attached is a screenshot: image

G-dH commented 2 months ago

@KSTRTK The AUR package has its own maintainer, and I am not sure how it gets updated. If you want to test the latest version, you need to install V-Shell directly from this repository. Instructions are in the README.

italoghost commented 2 months ago

Thanks. There is still some problem with folders in 47, I must have missed something in the GS commits...

Hi, @G-dH! Everytime I start a new session, my folders doesn't show the icons, as I have mentioned above. The workaround that I have found (and that is why I thought that I had solved the issue) is to change the icon size from one valor to another.

G-dH commented 2 months ago

The folder issue after login should be resolved now. Please try the latest update and let me know if it works for you.

italoghost commented 2 months ago

It is working! Thanks, @G-dH!

G-dH commented 2 months ago

Thanks for your help. Sending it to ego.