G-dH / vertical-workspaces

V-Shell is a GNOME Shell extension that allows you to customize the layout and behavior of the Shell UI.
GNU General Public License v3.0
230 stars 20 forks source link

Weird visual corruption issue with dash in horizontal position #202

Open dimitri-vanlanduyt opened 2 weeks ago

dimitri-vanlanduyt commented 2 weeks ago

I prefer placing the dock in the top position and I have been using this wonderful extension for that. However, since a few weeks, the rendering of the dock in that specific position has started suffering from a form of "visual corruption" (see screenshots), both in the rendering of the app icons, and in the tooltips below. It appears to first render them correctly and then it changes ( I can sometimes see the change happening). This is consistent. I experienced the issue in Gnome 3.36 (F40) and now also in Gnome 3.37 (F41).

I tried disabling all other plugins and the issue persists. It does not occur with the dock in a different position.

Weirdly, this corruption seems to happen along a line that gradually decreases (see final screenshot and compare icon per icon and where the shift is happening in the Y plane: this decreases). Perhaps this observation this may give a hint towards the root cause, most probably not.

To Reproduce Visualise the dock

Expected behavior No visual corruption

Screenshots Screenshot From 2024-10-31 07-32-16 Screenshot From 2024-10-31 07-26-19 Screenshot From 2024-10-31 07-40-50

System:

dimitri-vanlanduyt commented 2 weeks ago

It also occurs in the bottom position, but not when the dock is rendered vertically.

G-dH commented 2 weeks ago

Have you tried reproducing the issue with V-Shell disabled?

dimitri-vanlanduyt commented 2 weeks ago

Yes, without the V-Shell extension, the dock renders perfectly fine.

dimitri-vanlanduyt commented 2 weeks ago

I just noticed that it only occurs when the dock includes icons of running apps that are not pinned.

On a workspace that only has pinned apps open , the corruption does not occur.

Screenshot From 2024-10-31 08-11-49

G-dH commented 2 weeks ago

Wayland or X11? Graphics driver? Are you using any custom theme? Does disabling the dash module in the V-Shell Settings help?

dimitri-vanlanduyt commented 2 weeks ago

Wayland/amdgpu. No custom theme. Turning off the dash module put the dock to the bottom and does not have the corruption issue (but also not the isolation in workspaces feature).

I do isolate workspaces (so the dock changes when I switch workspace), and I notice that it doesn't occur when I turn that off. We are getting closer

G-dH commented 2 weeks ago

I do isolate workspaces (so the dock changes when I switch workspace), and I notice that it doesn't occur when I turn that off

I noticed in your previous post that you're using this option and tested it myself, but it doesn't cause the issue on my system. In any case, V-Shell doesn't control dash rendering, so we can only hope to find a workaround if I can reproduce the issue.

dimitri-vanlanduyt commented 2 weeks ago

It's ugly but functional. In case I come into new findings, I will share them here.

G-dH commented 2 weeks ago

You can try this, when overview is open and the glitch is visible:

Can you still see the glitch?

dimitri-vanlanduyt commented 2 weeks ago

Yes, the glitch is still visible after that.

G-dH commented 2 weeks ago

How about switching workspaces in the overview? Are the icons still being recreated with the glitch?

nsurvance commented 2 weeks ago

I wanted to hop in here because I am also having this same issue, but I keep my dock positioned horizontally at the bottom.

image

I similarly am having this issue on Gnome 45 (F40) and 46 (F41). V-Shell Version 70 Installed from Extensions Manager AMD, Wayland and I do have an icon theme installed through gnome tweaks.

I do NOT isolate work spaces though. Mine is consistent acrossed workspaces and the visual bug appears across all of them as long as there is an unpinned app loaded--

https://github.com/user-attachments/assets/c966ae06-4b7a-46dc-bac0-57d4e04f2761

Issue still occurs with no other extensions on--

image

And the problem only occurs when Vshell is enabled--

https://github.com/user-attachments/assets/a84215ad-3855-4954-835b-d077084e2c41

I can also confirm that the issue disappears when no non-pinned apps are open. And disabling/enabling the dash in looking glass didn't work for me either :(

G-dH commented 2 weeks ago

It seems the horizontal position of the dock might not be rounded.

G-dH commented 1 week ago

When the overview is open and the glitch is visible, please open the looking glass (Alt+F2 > lg > Enter), execute Main.overview.dash.allocation.x1 Main.overview.dash.allocation.x2 Main.overview.dash.allocation.y1 Main.overview.dash.allocation.y2 and show me the outputs.

dimitri-vanlanduyt commented 1 week ago

Screenshot From 2024-11-04 08-35-29

x1 = 394.5 y1 = 44 x2 = 1795.5 y2 = 156

G-dH commented 1 week ago

Thanks. Can you install the V-Shell from the repository and let me know if the fix helped?

dimitri-vanlanduyt commented 1 week ago

It solved the issue!! Thank you so much for the follow-up and the fix (I just bought you a few coffees)

G-dH commented 1 week ago

Thank you very much @dimitri-vanlanduyt! I really appreciate your feedback and support.