search

G6EJD / ESP32-e-Paper-Weather-Display

An ESP32 and 2.9", 4.2" or 7.5" ePaper Display reads Weather Underground data via their API and then displays the weather
Other
946 stars 206 forks source link

Low and high temperature in forecast #177

Closed hervema closed 2 years ago

hervema commented 2 years ago

Hello.

First, your code is awesome ! Great project. Thanks to share it !!!

I use your code with a Waveshare epaper 2.9inch. It works very well. However, I think there is a little problem on search for low and high temperature per day, in GetHighsandLows() function.

As you are looking for the first period of day between 08:00 and 10:00, typically it will be 9:00, there is after 5 readings to do to stay in the same day, and not 8 as in your code currently.

In my side, the data were wrong with 8 and correct with 5, I loaded the json in a editor and checked that.

Weather 2 9

Thanks !

Regards,

hervema

hervema commented 2 years ago

Hello.

Also, I noticed another problem. If you allow me, the forecast api as used, returns the forecast from the current datetime, so including some periods of the current day. In my opinion, the data of the day should be removed from the forecast array. I made the modifications on my side, but I let you consider if this is a problem for you or not :-)

Thank you!

Regards,

hervema