G6EJD / ESP32-e-Paper-Weather-Display

An ESP32 and 2.9", 4.2" or 7.5" ePaper Display reads Weather Underground data via their API and then displays the weather
Other
934 stars 203 forks source link

Error in common.h ? #255

Closed schroepfer closed 2 months ago

schroepfer commented 2 months ago

Hello, i'm using your code since many years and i wanted to update it for the new OWM API 3. I use Arduino 2.3.2 and installed the source-zip in the library.

With your example Waveshare_1_54.ino i get the following errors:

`In file included from C:\Users\Jürgen\AppData\Local\Temp.arduinoIDE-unsaved2024325-24144-1brrv0c.g6s1\Waveshare_1_54\Waveshare_1_54.ino:96: c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h: In function 'bool obtain_wx_data(WiFiClient&, const String&)': c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:118:3: error: expected primary-expression before '?' token ?lat={lat}&lon={lon} ^ c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:118:4: error: 'lat' was not declared in this scope ?lat={lat}&lon={lon} ^~~ c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:118:4: note: suggested alternative: 'stat' ?lat={lat}&lon={lon} ^~~ stat c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:118:13: error: expected ':' before '&' token ?lat={lat}&lon={lon} ^ : c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:118:14: error: 'lon' was not declared in this scope ?lat={lat}&lon={lon} ^~~ c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:118:14: note: suggested alternative: 'log' ?lat={lat}&lon={lon} ^~~ log c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:123:5: error: 'uri' was not declared in this scope uri += "&cnt=" + String(max_readings); ^~~ c:\Users\J�rgen\Documents\Arduino\libraries\ESP32-e-Paper-Weather-Display\src/common.h:126:34: error: 'uri' was not declared in this scope http.begin(client, server, 80, uri); ^~~ Multiple libraries were found for "WiFi.h" Used: C:\Users\Jürgen\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.15\libraries\WiFi Not used: C:\Users\Jürgen\Documents\Arduino\libraries\WiFiNINA exit status 1

Compilation error: exit status 1`

Do you have any idea?

Regards Juergen

G6EJD commented 2 months ago

Just delete this line in common.h

?lat={lat}&lon={lon}

I have corrected the issue and also modified the code to match the Arduino JSON v7 requirements I suggest you go to the repository and copy common.h in the src folder and past that into your version/copy in the libraries folder , or just download this repository again. I'm not sure if API 3.0 is ready yet.

schroepfer commented 2 months ago

Thank you! I will try IT. API 3.0 worked today.

Regards Juergen

G6EJD @.***> schrieb am Do., 25. Apr. 2024, 13:46:

I have corrected the issue and also modified the code to match the Arduino JSON v7 requirements I suggest you go to the repository and copy common.h in the src folder and past that into your version/copy in the libraries folder , or just download this repository again. I'm not sure if API 3.0 is ready yet.

— Reply to this email directly, view it on GitHub https://github.com/G6EJD/ESP32-e-Paper-Weather-Display/issues/255#issuecomment-2076992111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHT73OL7Y5QVFL3WMRN4AT3Y7DUIPAVCNFSM6AAAAABGYU2MDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZWHE4TEMJRGE . You are receiving this because you authored the thread.Message ID: @.***>

G6EJD commented 2 months ago

Yes, I've just tried API 3.0, they currently support the cnt= option, but I doubt they will after June'24, that will need some code revisions.

schroepfer commented 2 months ago

Thank you! With your new common.h it compiles and worked on my 1.54 ePaper.

PS: german umlauts are not displayed.

Regards Juergen (in Germany)

Am Do., 25. Apr. 2024 um 14:08 Uhr schrieb G6EJD @.***>:

Yes, I've just tried API 3.0, they currently support the cnt= option, but I doubt they will after June'24, that will need some code revisions.

— Reply to this email directly, view it on GitHub https://github.com/G6EJD/ESP32-e-Paper-Weather-Display/issues/255#issuecomment-2077029219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHT73OPCKQRUO4JNXLUHKGLY7DW4BAVCNFSM6AAAAABGYU2MDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGAZDSMRRHE . You are receiving this because you authored the thread.Message ID: @.***>

G6EJD commented 2 months ago

Try changing the suffix on the font names from f to e and you should get extended characters

schroepfer commented 2 months ago

Hmm... I can't follow... :-) i user your example "Waveshare_1_54.ino" I can't find fonts which end with suffix f. Only with *.h

include <Fonts/FreeMonoBold12pt7b.h>

include "epaper_fonts.h"

??

Regards Juergen

Am Fr., 26. Apr. 2024 um 12:23 Uhr schrieb G6EJD @.***>:

Try changing the suffix on the font names from f to e and you should get extended characters

— Reply to this email directly, view it on GitHub https://github.com/G6EJD/ESP32-e-Paper-Weather-Display/issues/255#issuecomment-2079110822, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHT73OJIRI5234WCV3SDPCDY7ITLBAVCNFSM6AAAAABGYU2MDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGEYTAOBSGI . You are receiving this because you authored the thread.Message ID: @.***>

G6EJD commented 2 months ago

My mistake, that’s because the 1.54 variant does t use the u8g library which does support accents.